zenphoto forums » Feature Requests

Making Zenphoto Wordpress friendly in 3 lines of code

(4 posts)

  1. Joen

    Member
    Joined: Sep '05
    Posts: 43

    Please, please, please consider making Zenphoto more Wordpress friendly.

    It's not so hard to integrate Zenphoto into Wordpress (so that templates share the syntax Wordpress themes do), it really only involves:

    1: editing zp-core/lib-gettext/gettext.inc and replacing
    function _($msgid) {
    return $msgid;
    }

    with

    if (!function_exists('_')) {
    function _($msgid) {
    return $msgid;
    }
    }

    2: turning off E_STRICT error reporting by removing instances of it from "zp-core/functions-basic.php".

    It would be so much easier for me to upgrade Zenphoto.

    Posted 3 years ago #

  2. Zenphoto development team
    sbillard

    Chief Developer
    Joined: May '07
    Posts: 9,818

    Maybe you should ask Wordpress to be more friendly to all other applications. If you do indeed need this change, then Wordpress is defining the funtions _($msgid) without also defining its full and proper version gettext($msgid)

    But since Zenphoto does not actually use this shortened version (such shortcuts are really bad programming practice, by the way) we will remove it.

    Don't forget to read the Forum rules and usage resources
    Posted 3 years ago #

  3. Joen

    Member
    Joined: Sep '05
    Posts: 43

    Let it be known first that my respect for Zenphoto outweighs my respect for Wordpress. I have no doubt that Zenphoto not only has prettier and better code.

    But I still appreciate it you'll tweak this. Thanks.

    As for the error reporting feature -- could it be made into an option in the admin, so that I didn't have to hack functions-basic.php? You could have it default to what it does now. I know I'm asking a lot.

    Posted 3 years ago #

  4. Zenphoto development team
    sbillard

    Chief Developer
    Joined: May '07
    Posts: 9,818

    Actually, that is already done in the next release. It was an oversite on 1.2.5. We want the test builds to have the E_STRICT so we see errors. But not the released versions. So now there is a decision based on if the version is a released one.

    Don't forget to read the Forum rules and usage resources
    Posted 3 years ago #

RSS feed for this topic

Reply

You must log in to post.